Skip to content

feat: keep list item gaps as written - #721

Open
ocavuebot wants to merge 3 commits into
masterfrom
feat/list-blank-before
Open

feat: keep list item gaps as written#721
ocavuebot wants to merge 3 commits into
masterfrom
feat/list-blank-before

Conversation

@ocavuebot

@ocavuebot ocavuebot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

List items get a blankBefore field (and list attr) that records whether one blank line separates them from the previous sibling. Loose lists stay loose, a two-block item no longer spreads blank lines over its whole list, and a list can start right under a paragraph. A shared canJoinTight check decides which gaps the serializer can write tight, and the parser records a tight gap only where it holds, so the tree reads back the same.

@vercel

vercel Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
meowdown Ignored Ignored Oct 24, 2026 4:13am UTC

@ocavuebot
ocavuebot added this pull request to stack #723 October 21, 2026 11:54
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 535358b1-8ea6-48bd-abed-dbb709ca2ef3
Commits

Reviewing files that changed from the base of the PR and between e63ad78 and bc6191b.

Files selected for processing: 16
  • .changeset/list-blank-before.md
  • packages/core/src/converters/ast-to-pm.ts
  • packages/core/src/converters/md-to-pm.test.ts
  • packages/core/src/converters/pm-to-ast.ts
  • packages/core/src/converters/pm-to-md.test.ts
  • packages/core/src/converters/roundtrip.test.ts
  • packages/core/src/converters/sample-content.ts
  • packages/core/src/extensions/extension.test.ts
  • packages/core/src/extensions/list.ts
  • packages/core/src/extensions/wililink-fuzz.test.tsx
  • packages/markdown/src/ast/check-roundtrip.test.ts
  • packages/markdown/src/ast/equal.ts
  • packages/markdown/src/ast/gap.ts
  • packages/markdown/src/ast/parse.ts
  • packages/markdown/src/ast/serialize.ts
  • packages/markdown/src/ast/types.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ocavuebot ocavuebot changed the title feat/list blank before feat: keep list item gaps as written Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026

Copy link
Copy Markdown

Preview: https://pr-721-meowdown.ocavue.workers.dev

@pkg-pr-new

pkg-pr-new Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@meowdown/core@721

npm i https://pkg.pr.new/@meowdown/embed@721

npm i https://pkg.pr.new/@meowdown/markdown@721

npm i https://pkg.pr.new/@meowdown/react@721

commit: bc6191b

@github-actions

github-actions Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 93.39% 6607 / 7074
🔵 Statements 92.12% 8084 / 8775
🔵 Functions 89.66% 1458 / 1626
🔵 Branches 88.38% 5481 / 6201
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/converters/ast-to-pm.ts 87.5% 95.12% 100% 86.66% 69-71
packages/core/src/converters/pm-to-ast.ts 86.66% 82.25% 100% 87.5% 34-37, 100
packages/core/src/converters/sample-content.ts 100% 100% 100% 100%
packages/core/src/extensions/list.ts 92.17% 91.83% 96% 92.03% 211-213, 257, 262, 267, 272, 479, 484
packages/markdown/src/ast/equal.ts 92.1% 85.29% 85.71% 90.32% 35-39, 98
packages/markdown/src/ast/gap.ts 94.23% 96.15% 100% 97.56% 24, 48, 61
packages/markdown/src/ast/parse.ts 97.89% 91.26% 100% 98.92% 338-341, 427, 440, 1022, 1031
packages/markdown/src/ast/serialize.ts 95.11% 92.55% 100% 96.8% 93, 191, 245-246, 275-279, 295, 335-336, 429-430, 449, 460, 487, 607, 669, 858, 944
packages/markdown/src/ast/types.ts 0% 0% 0% 0%
Generated in workflow #2954 for commit bc6191b by the Vitest Coverage Report Action

@ocavue
ocavue force-pushed the feat/list-blank-before branch from 6cb4cef to 6506e66 Compare October 24, 2026 04:13
Base automatically changed from feat/frontmatter-tight to master October 28, 2026 11:58
@ocavue
ocavue force-pushed the feat/list-blank-before branch from 6506e66 to bc6191b Compare October 28, 2026 11:58
@vercel

vercel Bot commented Oct 28, 2026

Copy link
Copy Markdown

Deployment failed for project meowdown with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/ocavues-projects?upgradeToPro=build-rate-limit

@ocavue
ocavue marked this pull request as ready for review October 28, 2026 11:58
@ocavue
ocavue self-requested a review as a code owner October 28, 2026 11:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocavue ocavue Awaiting requested review from ocavue ocavue is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ocavuebot @ocavue